Changeset 32 for plesonet_banners/trunk/templatetags/banners_tags.py

Timestamp:

05/07/09 19:39:02 (3 years ago)

Author:

235

Message:

optimized bannerplaces (no cache)

Files:

• plesonet_banners/trunk/templatetags/banners_tags.py (modified) (3 diffs)

plesonet_banners/trunk/templatetags/banners_tags.py

@@ -2 +2 @@
 from apps.plesonet_banners.models import Bannerpage, Banners 
 from django.template import Library
+from apps.lib.threadlocals import get_request
+
+from scache.tags import cached_inclusion_tag
+from django.db.models import signals 
 
 register = Library()
+
 
 @register.inclusion_tag('plesonet_banners/show_banner.html', takes_context=True)
@@ -11 +16 @@
     url = context['request'].path
     
-    # banner only this page
     banners = Banners.objects.filter(
                                     bannerplace__is_published=True, 
-                                    bannerplace__url__iexact=url, 
                                     is_published=True, 
                                     bannertype=banner_type)
     
-    if banners:
-        return {'banner': banners[0]}
+    
+    #better to find proper banner on client-side, than making a dozen of sql requests
+    for b in banners:
+        if b.bannerplace.url == url and b.child_page_only == False:
+            return {'banner': b}    
     
     # last word
     url = url.rsplit('/',1)[0]
+    if url == "":
+        return {'banner': None}
     
     # parent banners
@@ -28 +36 @@
        url = url.rsplit('/',1)[0]
        select_url = url + '/'
-       
-       banners = Banners.objects.filter(
-                                        bannerplace__is_published=True, 
-                                        bannerplace__url__iexact=select_url, 
-                                        is_published=True, 
-                                        bannertype=banner_type)
-       
-       if banners:
-           if not banners[0].one_page_only:
-               banner = banners[0]
-               break
+              
+       for b in banners:
+           if b.bannerplace.url == select_url and not b.one_page_only:
+               return {'banner': b}
        
        if url.find('/') : break  
         
-    return {'banner': banner}
+    return {'banner': None}